Fix: Sanitize SVG to prevent Stored XSS (Fixes #5514)#5515
Open
jeongbeannnn wants to merge 5 commits intogoogle:mainfrom
Open
Fix: Sanitize SVG to prevent Stored XSS (Fixes #5514)#5515jeongbeannnn wants to merge 5 commits intogoogle:mainfrom
jeongbeannnn wants to merge 5 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add _sanitize_svg_content() function to remove XSS vectors - Sanitize SVG artifacts before returning from load_artifact() - Remove foreignObject, script tags, and event handler attributes - Add comprehensive unit tests for XSS prevention - Verified with Docker v1.30.0 test cases
jeongbeannnn
force-pushed
the
fix/svg-xss-sanitization
branch
from
c219054 to
0509ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a Stored XSS vulnerability in the ADK web development UI that allows arbitrary JavaScript execution via malicious SVG artifacts (Issue #5514).
Changes
_sanitize_svg_content()function to remove XSS vectors from SVG contentload_artifact()to sanitize SVG artifacts before returning to clients<foreignObject>,<script>tags, and event handler attributesTechnical Details
Vulnerability
The vulnerability exists because the web dev UI uses Angular's
bypassSecurityTrustHtml()to render SVG content without prior sanitization. An attacker can craft a malicious SVG artifact containing:<foreignObject>elements with embedded XHTMLonerror,onload,onclickWhen a developer views the artifact in the dev UI, the XSS payload executes with full access to the developer's credentials and session.
Fix Strategy
Server-side SVG sanitization using regex-based filtering:
<foreignObject>elements completely<script>tagsjavascript:URLsTesting
tests/unittests/cli/test_svg_sanitization.pyVerification
<script>tags ✓References